GH-50808: [Python] Narrow Feather deprecation to V1 format - #50685
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
rok
requested changes
Aug 4, 2026
github-actions
Bot
added
awaiting changes
tadeja
force-pushed
the
fup-49590-V1-only
branch
from
August 4, 2026 11:23
d1d5428 to
ae7b403
Compare
tadeja
changed the title
Co-authored-by: Rok Mihevc <rok@mihevc.org>
Member
|
@jorisvandenbossche could you please do a quick check so we perhaps get this into patch release today? |
rok
approved these changes
Aug 4, 2026
github-actions
Bot
added
awaiting merge
Collaborator
Author
|
@github-actions crossbow submit preview-docs |
|
Revision: fcfd9a6 Submitted crossbow builds: ursacomputing/crossbow @ actions-a52a1106a3
|
jorisvandenbossche
approved these changes
Aug 4, 2026
jorisvandenbossche
left a comment
jorisvandenbossche
left a comment
Member
There was a problem hiding this comment.
Based on a very cursory look, this looks good to me!
rok
changed the title
raulcd
pushed a commit
that referenced
this pull request
Aug 4, 2026
### Rationale for this change Follow-up to #49232 (comment) / #49590 ### What changes are included in this PR? Remove warnings from `write_feather()`, `read_feather()`, `read_table()`, and `FeatherDataset`. Warn **only** on writing with `version=1` / reading Feather V1 file. Update docs to V1-only and keep IPC migration guide. Additionally corrected notes like `deprecated as of 24.0.0` to `25.0.0` instead. `DeprecationWarning` in place of current `FutureWarning`. ### Are these changes tested? Yes, by CI. ### Are there any user-facing changes? Yes! Feather V2 APIs no longer emit deprecation warnings. Reading/writing the legacy Feather V1 format emits `DeprecationWarning` in place of `FutureWarning`. * GitHub Issue: #50808 Lead-authored-by: Tadeja Kadunc <tadeja.kadunc@gmail.com> Co-authored-by: tadeja <tadeja@users.noreply.github.com> Co-authored-by: Rok Mihevc <rok@mihevc.org> Signed-off-by: Rok Mihevc <rok@mihevc.org>
Member
|
The previews of changed docs: |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 7ef5982. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 7 possible false positives for unstable benchmarks that are known to sometimes produce them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Follow-up to #49232 (comment) / #49590
What changes are included in this PR?
Remove warnings from
write_feather(),read_feather(),read_table(), andFeatherDataset.Warn only on writing with
version=1/ reading Feather V1 file.Update docs to V1-only and keep IPC migration guide.
Additionally corrected notes like
deprecated as of 24.0.0to25.0.0instead.DeprecationWarningin place of currentFutureWarning.Are these changes tested?
Yes, by CI.
Are there any user-facing changes?
Yes!
Feather V2 APIs no longer emit deprecation warnings.
Reading/writing the legacy Feather V1 format emits
DeprecationWarningin place ofFutureWarning.